replace Imgur with GitHub Release Assets for screenshot hosting#3573
replace Imgur with GitHub Release Assets for screenshot hosting#3573probonopd merged 3 commits intoAppImage:masterfrom
Conversation
Fixes AppImage#3548 ## Problem Imgur API returns "Too Many Requests" errors (code 1025), blocking successfully tested applications from being merged. ## Solution Replace Imgur with GitHub Release Assets: - Screenshots are uploaded to a draft release named 'ci-screenshots' - Inline images displayed in PR comments - Works for PRs from external contributors using workflow_run trigger
|
@probonopd |
- Add step to sanitize screenshot filenames before upload - Remove invalid characters (: * ? < > |) from app names - Fixes error with apps like 'fre:ac' containing colons - Update publish workflow to handle flat file structure
AshBuk
force-pushed
the
replace-imgur-with-github-releases
branch
from
29420f9 to
36d2f39
Compare
| github.event.workflow_run.conclusion == 'success' && | ||
| github.event.workflow_run.event == 'pull_request' | ||
| github.event.workflow_run.event == 'pull_request' && | ||
| github.repository == 'AppImage/appimage.github.io' |
There was a problem hiding this comment.
This prevents workflow execution in forks - ensures releases and PR comments
are only created in the upstream repository.
| COUNT=0 | ||
| FALLBACK="run-${{ github.event.workflow_run.id }}" | ||
| for f in out/screenshots-upload/*.png; do | ||
| for f in out/*.png; do |
There was a problem hiding this comment.
screenshots are now extracted directly to out/
(matching the actual artifact structure)
|
|
||
| - name: Ensure draft release exists | ||
| - name: Ensure release exists (published) | ||
| shell: bash |
There was a problem hiding this comment.
publish release (not draft) so that URLs render as inline images in PR comments, not just clickable links
|
Thank you very much @AshBuk. Let's try this out. It'd be even more elegant if we wouldn't need artifacts or releases for this, but I understand GitHub doesn't allow for posting comments in PRs with pictures via API directly yet. |
|
Hello @AshBuk could you please have a look as to why no screenshot has been posted to Looking at the Release, screenshots seem to have been taken. Thanks! |
|
Hi @probonopd ! check #3577 If permissions are enabled but the bot still doesn’t run in the upstream repo, I’ll dig into it tomorrow and will try provide a fix. |
2 participants
Fixes #3548
Problem
Imgur API returns "Too Many Requests" errors (code 1025), blocking successfully tested applications from being merged.
Solution
Replace Imgur with GitHub Release Assets:
Workflow
Security
1. Separation of contexts:
2. Does not execute code from PR in privileged context:
Reference: Keeping your GitHub Actions and workflows secure: Preventing pwn requests